search

maxtepkeev / architect

A set of tools which enhances ORMs written in Python with more features
Other
391 stars 57 forks source link

Bigint range partition in postgresql #3

Closed nickspring closed 9 years ago

nickspring commented 9 years ago

Hello! Please review my code, maybe will possible to include it in new version of Architec. Thank you Nikolay

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.78%) when pulling 4871c00a14f737cd9bb5921aee56a1ad9dd2ac68 on nickspring:master into 93c58c568d71ae14bd4fe9c7b1bfed2cbf4aaf70 on maxtepkeev:master.

maxtepkeev commented 9 years ago

Hi!

Sorry for the late response. I had a 3 week vacation and didn't have an internet access.

Thanks for the contribution, I will try to review your code ASAP and include it in the next release if all goes well.

nickspring commented 9 years ago

111

Hi!

Sorry for the late response. I had a 3 week vacation and didn't have an internet access.

Thanks for the contribution, I will try to review your code ASAP and include it in the next release if all goes well.

— Reply to this email directly or view it on GitHub.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 2e320249da6986e5fcc0060819d8b210bc6dd8a7 on nickspring:master into \ on maxtepkeev:master**.

maxtepkeev commented 9 years ago

Hi!

I know it's kind of a late, but better late than never ;-)

Unfortunately I had a very busy year and I didn't have a time to work on this project. Fortunately, everything has changed now, I did a big refactoring on the whole project, including PostgreSQL triggers, that is why it became impossible to merge your pull request, so I took some parts of your code and implemented them following the new API in 2244d53e3cc157016ba559f4d99c9d0263395902.

I also added support for numbers that are <= 0, because your version didn't support them properly, tests for all ORMs and a "thank you" to the changelog.

Once again thank you for the work you've done. If you have any more ideas about partitioning types or want to send new pull requests - you're more than welcome, I promise, this time it won't take so much time to merge it.

Thanks.