maxtepkeev / architect

A set of tools which enhances ORMs written in Python with more features
Other
391 stars 57 forks source link

Add return_null option for partition #45

Open soyking opened 7 years ago

soyking commented 7 years ago

As described in #26 #43, use RETURN NULL could accelerate the insert action. So here I add the return_null option when use architect.install. It will create the before-insert-trigger without return value and won't create the after-insert-trigger in PostgreSQL.

But there are many limitations:

It's ok if the MR won't be merged since there are too many limitations which should be declare cleary in documents. Actually I want to know if it could pass the tests in travis :)

soyking commented 7 years ago

hmm… werid error, seems irrelevant with the changes

maxtepkeev commented 7 years ago

I restarted the job and tests are passing now. You're right, there're some limitations which I need to think about before considering whether to merge this or not. Anyway great work, really appreciate it. Let's keep this PR open for a while.