Closed jhiker closed 7 months ago
@jhiker Sorry, I gave this a quick approval yesterday, but I believe the already published 0.2.0.2
is the one you want for the loosened Hash type (which might already be pulled into CW).
I released 0.2.0.2
(release) and 0.2.1
(release) at the same time, both of which included an important bug fix. The only difference is that 0.2.0.2
has the loosened Hash type that you're trying to add in this PR. main
branch includes a lot of unreleased work (that I need to get a jump on, thanks for the kick in the pants!).
I did a poor job publicizing this because I thought these would be quick-lived versions, but alas.
In short, I think you already have this behavior in CW. I'd be happy to chat more if you're not seeing it, and I'll be looking to release a 0.3.0
soon. It will have a few breaking changes.
No worries!
Thanks for the quick response.
I’ll take with the team. FYI, we finally bought LaunchDarkly a few weeks ago. Ryan, who just joined, threw together this Launchdarkly provider this past week or so.
https://github.com/justworkshr/openfeature-launchdarkly-provider/
Feel free to take a look — the only thing is some issue with stable initialization of the SDK, likely due to Rails lazy loading, etc and we’re both Ruby naïfs. We gotta debug a bit to get it into CW.
Hope you and the fam are doing well and getting some sleep. All the best.
Btw I’ll be back in Winter Park this holiday season in case you’re around to grab a beer.
Jon
On Fri, Dec 1, 2023 at 6:10 AM Max VelDink @.***> wrote:
@jhiker https://github.com/jhiker Sorry, I gave this a quick approval yesterday, but I believe the already published 0.2.0.2 is the one you want for the loosened Hash type (which might already be pulled into CW).
I released 0.2.0.2 and 0.2.1 at the same time, both of which included an important bug fix. The only difference is that 0.2.0.2 has the loosened Hash type that you're trying to add in this PR. main branch includes a lot of unreleased work (that I need to get a jump on, thanks for the kick in the pants!).
I did a poor job publicizing this because I thought these would be quick-lived versions, but alas.
In short, I think you already have this behavior in CW. I'd be happy to chat more if you're not seeing it, and I'll be looking to release a 0.3.0 soon. It will have a few breaking changes.
— Reply to this email directly, view it on GitHub https://github.com/maxveldink/openfeature-sdk-sorbet/pull/18#issuecomment-1835905046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCBLN3TGSKCPFBRUIHQOB3YHG3KRAVCNFSM6AAAAABABYYYXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVHEYDKMBUGY . You are receiving this because you were mentioned.Message ID: @.***>
Ah gotcha. Thanks @maxveldink for the clarification. My local CW was pulling down 0.2.0
, but we will need MultipleSourceProvider
to pass context
. This was fixed in 0.2.1
. (This fix is not currently in main
yet. see here ). My intent with requesting this PR was a low-pri maintenance merge to bring that fix back into main
.
Should we add https://github.com/justworkshr/openfeature-launchdarkly-provider/ before you have time to upgrade to 0.3.0
, I can bump the version in CW's gemfile to make it explicit during installs.
Thanks again @maxveldink and @jhiker
As part of our work setting up LaunchDarkly provider, we would like to merge this into main.