search

maxwell / screencap

A gem to screencap webpages in ruby. Uses Phantom.js under the hood.
MIT License
179 stars 63 forks source link

Remove injection and dependency on jQuery #28

Open DEfusion opened 8 years ago

DEfusion commented 8 years ago

For some reason the jQuery URL inject started not to load for me causing the callback to not run and the window to not be resized anymore. It isn't really needed for the things we were using it for so removed it and used DOM to do the same things.

ryana commented 8 years ago

Interesting. I solve this in a slightly different way: https://github.com/ramen-dev/screencap/commit/24f6914333e2aef3cecf9c8ae8c25f4acc8b7e14

This lets me rely on the jQuery embedded in the if it exists & lets me override the URL.

maxwell commented 8 years ago

merge away!