maxwellhadley / node-red-contrib-rfxcom

node-RED nodes to access an RFXtrx433 transceiver
BSD 2-Clause "Simplified" License
22 stars 13 forks source link

Node.js 10 #50

Closed DR-Automation closed 5 years ago

DR-Automation commented 6 years ago

Node does not work with latest node JS 10

maxwellhadley commented 6 years ago

I'm not surprised. The package depends on node-rfxcom which in turn depends on serialport, which as far as I know does not yet support JS 10 - they have a policy of 'LTS versions only'.

What exactly happens?

DR-Automation commented 6 years ago

It stops the flow and does have warnings related to serial port, had to wipe the system and start again as rolling back to v8.11.1 LTS would not get it to work again

maxwellhadley commented 6 years ago

I've started work on switching node-rfxcom to serialport v6, which should fix this issue

DR-Automation commented 6 years ago

Thanks

maxwellhadley commented 5 years ago

Should be fixed now, with node-rfxcom version 1.4.0, though I have not tested on ARM architecture (yet). Please give it a whirl

maxwellhadley commented 5 years ago

@DR-Automation Did you get it running under NodeJS 10? I'd like to close the issue if you are happy now.

DR-Automation commented 5 years ago

Hi, Yes it runs with NodeJS 10, had to delete my flows and uninstall node-red-contrib-rfxcom then re-installed and it is working.

From: Max Hadley notifications@github.com Sent: 29 July 2018 10:18 To: maxwellhadley/node-red-contrib-rfxcom node-red-contrib-rfxcom@noreply.github.com Cc: Info info@drautomation.co.uk; Mention mention@noreply.github.com Subject: Re: [maxwellhadley/node-red-contrib-rfxcom] Node.js 10 (#50)

@DR-Automationhttps://github.com/DR-Automation Did you get it running under NodeJS 10? I'd like to close the issue if you are happy now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/maxwellhadley/node-red-contrib-rfxcom/issues/50#issuecomment-408663327, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjvW4eo9vgq0Y-QxsIehiR31H4grPS_dks5uLX3UgaJpZM4T_f6m.

maxwellhadley commented 5 years ago

OK Thanks!