search

maxwells / bootstrap-tags

Bootstrap-themed jquery tag interface
MIT License
549 stars 134 forks source link

CaseSensitive suggestions bug if tags start with an uppercase letter #34

Closed danjor closed 10 years ago

danjor commented 10 years ago

Hi,

There is a bug with suggestions if tags in suggestions start with an uppercase letter /!\ For instance, if suggestions are ["Alpha", "bravo"], typing :

With option caseInsensitive: false "a" will suggest "Alpha" -> problem as caseInsensitive is false "A" WON'T suggest "Alpha" -> that's the problem "b" will suggest "bravo" "B" won't suggest "bravo"

With option caseInsensitive: true "a" won't suggest "Alpha" "A" WON'T suggest "Alpha" -> that's the problem "b" will suggest "bravo" "B" will suggest "bravo"

Also, caseInsentive:true works only if tags in suggestions are in lowercase.

This is a real problem if you are using a smartphone which as keyboard set to enter an uppercase letter first, suggestions will never appear. Ex : iPhone 5.

Is this a know bug ?

Thanks,

Danjor.

maxwells commented 10 years ago

Hi Danjor -- Thanks for bringing this to my attention. I'll include in v1.1.3

Just for clarification, the following things should be true for a set of suggestions: ["alpha", "Bravo", "charlie"]:

caseInsensitive: true: "A" should suggest ["alpha"] "a" should suggest ["alpha"] "B" should suggest ["Bravo"] "b" should suggest ["Bravo"]

caseInsensitive: false: "a" should suggest ["alpha"] "A" should suggest [] "b" should suggest [] "B" should suggest ["Bravo"]

maxwells commented 10 years ago

Included in version 1.1.3: https://github.com/maxwells/bootstrap-tags/tree/1.1.3