search

maxwo / snmp_notifier

A webhook to relay Prometheus alerts as SNMP traps, because sometimes, you have to deal with legacy
Apache License 2.0
57 stars 34 forks source link

Release new version to get newer docker image #208

Closed falk-w closed 1 month ago

falk-w commented 2 months ago

I see a new main image got built after v1.5.0 has been built quite a while ago (10 months).

Would it be possible to bump the version also to get a newer docker image? (Your Go Bump had some security fixes e.g. https://github.com/golang/go/issues/67680 and I'd like to see them in an image that can be referenced in the official helm chart - https://github.com/prometheus-community/helm-charts/tree/main/charts/alertmanager-snmp-notifier )

maxwo commented 1 month ago

Good point indeed. I just released the v1.6.0 that uses the latest Golang images.

$ docker run maxwo/snmp-notifier:v1.6.0 --version
snmp_notifier, version 1.6.0 (branch: HEAD, revision: a7a4593a9db0b46746403d0d338518111a0aabc8)
  build user:       root@e85efbf57b23
  build date:       20240929-08:25:40
  go version:       go1.23.1
  platform:         linux/arm64
  tags:             netgo

I will update the chart to reference that new version. Until then, you can customize the image.tag value of the current chart to take it into account.

falk-w commented 1 month ago

Good point indeed. I just released the v1.6.0 that uses the latest Golang images.

$ docker run maxwo/snmp-notifier:v1.6.0 --version
snmp_notifier, version 1.6.0 (branch: HEAD, revision: a7a4593a9db0b46746403d0d338518111a0aabc8)
  build user:       root@e85efbf57b23
  build date:       20240929-08:25:40
  go version:       go1.23.1
  platform:         linux/arm64
  tags:             netgo

I will update the chart to reference that new version. Until then, you can customize the image.tag value of the current chart to take it into account.

Thanks! FYI: The chart automatically uses the appversion so if the appversion is bumped, it should be sufficient!

maxwo commented 1 month ago

Yes, but I was willing to add another feature in the chart. I will do a simple PR just for the appVersion though.

maxwo commented 1 month ago

Helm chart PR: https://github.com/prometheus-community/helm-charts/pull/4893

Needs to be merged, but that ends that issue. Thank you

maxwo commented 1 month ago

FYI, Helm Chart PR has been merged.

falk-w commented 4 weeks ago

FYI, Helm Chart PR has been merged.

Thanks! I was also monitoring this, great work!