mayadata-io / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/product/weave-scope/
Apache License 2.0
22 stars 26 forks source link

Add support for CSPC and CSPI #173

Closed qiell closed 5 years ago

qiell commented 5 years ago

This PR will

Each CSPI will have a label openebs.io/cstor-pool-cluster containing the CSPC name which is used to link CSPC and CSPI. CSPI will also have block devices list, which is used to link CSPI and BlockDevices.

A CVR will have a label related to SPC or CSPC object. If a volume is provisioned using CSI provisioner, then the CVR object will have a label related to CSPC object i.e. cstorpoolinstance.openebs.io/uid else it will have a label related to SPC object cstorpool.openebs.io/uid which is used to link CVR to CSPC or SPC depending on the label.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1995


Changes Missing Coverage Covered Lines Changed/Added Lines %
probe/kubernetes/cstor_volume_replica.go 0 12 0.0%
probe/kubernetes/reporter.go 22 34 64.71%
render/detailed/summary.go 0 12 0.0%
probe/kubernetes/cstor_pool_cluster.go 0 13 0.0%
render/cstorvolume.go 1 16 6.25%
probe/kubernetes/client.go 0 20 0.0%
probe/kubernetes/cstor_pool_cluster_instance.go 0 22 0.0%
render/storagerenderer.go 8 30 26.67%
probe/kubernetes/controls.go 0 56 0.0%
<!-- Total: 43 227 18.94% -->
Files with Coverage Reduction New Missed Lines %
probe/kubernetes/cstor_volume_replica.go 1 0.0%
app/multitenant/consul_client.go 3 51.92%
render/detailed/detailed.codecgen.go 1888 28.67%
report/report.codecgen.go 2847 34.94%
<!-- Total: 4739 -->
Totals Coverage Status
Change from base Build 1952: -0.04%
Covered Lines: 14928
Relevant Lines: 56113

💛 - Coveralls
satyamz commented 5 years ago

Hi @qiell Can you please add description about how these CRDs are linked and what changes this PR cover?