Closed ibreakthecloud closed 4 years ago
/assign @avrahul
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
app/multitenant/consul_pipe_router.go | 6 | 77.74% | ||
render/detailed/detailed.codecgen.go | 1337 | 28.65% | ||
report/report.codecgen.go | 2559 | 34.96% | ||
<!-- | Total: | 3902 | --> |
Totals | |
---|---|
Change from base Build 2127: | -0.004% |
Covered Lines: | 14930 |
Relevant Lines: | 56021 |
PR looks fine @ibreakthecloud !! Thanks. Can you please add some code comments to know what exactly is this and how a user can request for the same?
Inside JSX, scope doesn't really have any comments, but yes the place where zenMode
is defined I will definitely add a comment and it's usage. But if you want I will put in JSX as well
zenMode: This is the mode where scope will render just the topology, no header and footer, ideal for scope with smaller iframe(embedded frames)
zenMode
and read from URLWithout ZenMode With ZenMode
Signed-off-by: ibreakthecloud harshvardhan.karn@mayadata.io