mayadata-io / scope

Monitoring, visualisation & management for Docker & Kubernetes
https://www.weave.works/product/weave-scope/
Apache License 2.0
22 stars 26 forks source link

Add support for zen mode in scope #177

Closed ibreakthecloud closed 4 years ago

ibreakthecloud commented 4 years ago

zenMode: This is the mode where scope will render just the topology, no header and footer, ideal for scope with smaller iframe(embedded frames)

Without ZenMode image With ZenMode image

Signed-off-by: ibreakthecloud harshvardhan.karn@mayadata.io

ibreakthecloud commented 4 years ago

/assign @avrahul

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2175


Files with Coverage Reduction New Missed Lines %
app/multitenant/consul_pipe_router.go 6 77.74%
render/detailed/detailed.codecgen.go 1337 28.65%
report/report.codecgen.go 2559 34.96%
<!-- Total: 3902 -->
Totals Coverage Status
Change from base Build 2127: -0.004%
Covered Lines: 14930
Relevant Lines: 56021

💛 - Coveralls
ibreakthecloud commented 4 years ago

PR looks fine @ibreakthecloud !! Thanks. Can you please add some code comments to know what exactly is this and how a user can request for the same?

Inside JSX, scope doesn't really have any comments, but yes the place where zenMode is defined I will definitely add a comment and it's usage. But if you want I will put in JSX as well