search

mayah / tinytoml

A header only C++11 library for parsing TOML
BSD 2-Clause "Simplified" License
167 stars 31 forks source link

Remove return statements after failwith() #18

Closed mrkline closed 7 years ago

mrkline commented 7 years ago

All the compilers I've run tinytoml against (GCC 5, Clang 3.9, VS 2015) correctly understand that failwith() doesn't return, and warn about these returns being unreachable with certain warning flags.

mayah commented 7 years ago

Hi, code itself looks good to me. Let me check it with a bit older compiler, e.g. gcc 4.7, or clang 3.4. (I need to use them for a while). I'll do that today (in Japan time).

mayah commented 7 years ago

Confirmed.

mrkline commented 7 years ago

Awesome! Thanks for such a quick turnaround.