search

mayah / tinytoml

A header only C++11 library for parsing TOML
BSD 2-Clause "Simplified" License
167 stars 31 forks source link

Fix compiler warnings #5

Closed mjkoo closed 8 years ago

mjkoo commented 8 years ago

Hello! In using this library clang produced several warnings which I've addressed. Of note, it looks like in several places the bool Token constructor was being called when likely the string one was desired. The rest of the changes I don't think fix any correctness issues, and mostly were to make clang happy.

If you're interested in reproducing my compiler warning output, I was building with -Werror -Wall -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-padded -Wno-weak-vtables -Wno-global-constructors -Wno-exit-time-destructors -Wno-gnu-zero-variadic-macro-arguments -Wno-unused-member-function -Wno-switch-enum -Wno-covered-switch-default

mayah commented 8 years ago

Really thanks for the PR. I'm OK with merging this as is, but Let me comment a few things to make the PR better. (If no response, I will merge this and rewrite later.)

mjkoo commented 8 years ago

No problem! Latest commit should address your comments here.

mayah commented 8 years ago

LGTM. Thanks for addressing the comments immediately. I really appreciate it.