search

mayank-prasoon / world-maker

A world building app
https://chunkydev.itch.io/world-maker
MIT License
143 stars 5 forks source link

Linked Map - map pin property causing cyclic dependency. #39

Closed mayank-prasoon closed 2 years ago

mayank-prasoon commented 2 years ago

Describe the bug A cyclic error occurs when linking a map via linked map pin properties. This happens when the Map has a pin that tries to load itself which confuses the engine. More explanation :- Video by Godot tutorial explaining this. Apparently it only happens when loading something. The already cached will work normally without any error.

To Reproduce Steps to reproduce the behaviour:

  1. Select any map
  2. Right Click → New → Pin (new pin will be added to the map)
  3. Select the current map
  4. Right Click → go to map (to check if it's working)
  5. Exit
  6. Reopen the app

Expected behaviour The app should just open normally and does not cause any error

mayank-prasoon commented 2 years ago

Well looks like removing the ability to assign itself as a linked map was enough to fix the problem.