Closed khronokernel closed 3 years ago
@khronokernel thank you for the suggestions. I don't think I have time to work on this project at the moment but I'll keep these in mind.
Monterey support will be added eventually (at worst around or before public release/release candidate). Thank you again, I'll revisit your suggestions in the future.
Currently with kryptonite you support reading the configuration variables from boot-args, one suggestion would be to support reading from both boot-args and dedicated NVRAM entries. Example:
4D1FDA02-38C7-4A6A-9CC6-4BCCA8B30102
GUID is OpenCore/Lilu's GUID and is commonly used by other community kexts. The idea of reading NVRAM variables directly can be found in RtcMemoryFixup (RTC ranges can be defined either with the boot-argrtcfx_exclude=xxx
or with the stand alone variablertc-blacklist
. Boot-args will take precedence over dedicated args).The goal of this would be to reduce the clutter in boot-args, however whether you feel this is beneficial is up to you.
Side Notes
1. Fixing Sandy and ivy Bridge Audio support
Noticed in your README the reference to patched DSDT:
With OpenCore Legacy Patcher, we've actually found a safer solution where we override the
BUF0
Object with a combination of SSDT and ACPI patch:Feel free to implement in your own work, it would be quite a bit safer compared to using a patched DSDT which can cause issues with firmware updates
2. Monterey support
Noticed in your source you limit your kext to Big Sur support, are there currently any concerns with Monterey support? Or is this simply validation concerns/kext was in development before Lilu supported Monterey and thus
KernelVersion::BigSur
was left