anshulkgupta
commented
8 years ago I don't get it -- why can't you just commit the JSON and have the million files in our git?
On Sun, Dec 20, 2015 at 1:49 PM, Evan Tarrh notifications@github.com wrote:
Literally had to reclone the repo because i couldn't undo all the fucked up history rewriting shit I did. Anyway, these tests won't work without the JSONs. I'll put 'em in slack or something. You can view, comment on, or merge this pull request online at: https://github.com/mayankmahajan24/QL/pull/52 -- Commit Summary --
- configuring gitignore for large jsons
- extensive bugfixes, preparing for integration tests
adding working integration tests 1-4 -- File Changes -- M .gitignore (4) M compiler/code_generator.ml (22) M compiler/environment.ml (4) M compiler/semantic.ml (52) M compiler/semantic_to_jast.ml (4) A tests/integration-1-exp.out (63) A tests/integration-1.ql (8) A tests/integration-2-exp.out (2) A tests/integration-2.ql (17) A tests/integration-3-exp.out (2) A tests/integration-3.ql (19) A tests/integration-4-exp.out (2) A tests/integration-4.ql (62) -- Patch Links -- https://github.com/mayankmahajan24/QL/pull/52.patch https://github.com/mayankmahajan24/QL/pull/52.diff
Reply to this email directly or view it on GitHub: https://github.com/mayankmahajan24/QL/pull/52
Introduces integration tests via
run_integration_tests.sh. This way,run_tests.shwill still work for anyone who just clones the repo and runs them. You'll need the right formatted JSONs to make the integration tests pass. I'll put them in Slack.Also, this PR fixes several bugs along the way—we didn't open issues for them, but you can look at the changes to anything in
compiler/if you're curious. Shoutout to Mayank, who crushed this stuff last night (killsteal on those commits)I think the most presentable integration tests are 1, 4, and 5—let me know what you think!