search

maybe-finance / maybe

The OS for your personal finances
https://maybe.co
GNU Affero General Public License v3.0
30.99k stars 2.31k forks source link

Feature: duplicate transaction detection for CSV imports #1214

Open mgirouard opened 2 weeks ago

mgirouard commented 2 weeks ago

Describe the bug After a few weeks of using Maybe, I noticed that I find myself deleting duplicate transactions often. I regularly export CSVs from my banks and import them. It's easier for me to grab the last 30 days of activity and import them without having to grab specific dates, but when I do this I always wind up with duplicates.

To Reproduce Steps to reproduce the behavior:

  1. Go to any account
  2. Click on the ellipsis (...) menu and select Import transactions
  3. Follow the normal import flow (adjust fields, adjust data, confirm transactions)
  4. Navigate back to the account and review the latest transactions

(Perhaps a quicker repro would be to create a temporary account and import transactions twice)

Expected behavior Duplicate transactions should be filtered out and not be imported.

Screenshots / Recordings n/a

Additional context Perhaps this could be done by hashing the transaction data -- exact matches would be a high probability of being duplicates (same description, same amount, same date, etc).

There will almost certainly be edge cases though -- eg: if I intentionally make the same purchase twice. One of the screens during import might be a good place to call this out and give me a checkbox to import it in or not.

NGUYENDUCCHUNG21 commented 2 weeks ago

This text is italicized

zachgoll commented 2 weeks ago

@mgirouard currently, we do not have any support for detecting duplicates, but I agree that the feature would be useful.

I agree with you that hashing the raw transaction data is probably the best option for detecting matches.

What I'm not 100% sure about is the UI/UX for this (cc @justinfar)

My guess is that we could provide some sort of duplicate filtering / removal in our "clean" step?

CleanShot 2024-09-30 at 10 17 35@2x

mgirouard commented 2 weeks ago

@zachgoll Yeah, this makes the most sense to me. Thanks for considering :)

NGUYENDUCCHUNG21 commented 2 weeks ago

Cái gì dậy ?

Vào Th 3, 1 thg 10, 2024 lúc 09:00 Michael Girouard < @.***> đã viết:

@zachgoll https://github.com/zachgoll Yeah, this makes the most sense to me. Thanks for considering :)

— Reply to this email directly, view it on GitHub https://github.com/maybe-finance/maybe/issues/1214#issuecomment-2384630418, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLWVJVPLQ7RF4GJPDAWKDKDZZH64PAVCNFSM6AAAAABPB2TCV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUGYZTANBRHA . You are receiving this because you commented.Message ID: @.***>