maybe-finance / maybe

The OS for your personal finances
https://maybe.co
GNU Affero General Public License v3.0
29.2k stars 2.22k forks source link

Bug: pie chart on dashboard does not support multi-currency formatting #842

Closed AurelienConte closed 3 weeks ago

AurelienConte commented 2 months ago

Where did this bug occur?

Describe the bug

On the dashboard after adding my first checking account the assets graph is showing my checking account value with an "undefined" value.

To Reproduce

Expected behavior

I expect to show my account value but without the undefined keyword

Screenshots / Recordings

image

AurelienConte commented 2 months ago

By the way i'm looking for some "Good first issue" to start working on the project and i think this can be a good one !

EDIT : If i look to the pie_chart_controller.js it seems that the fractionalPart is undefined in my case but displayed in any case instead of displayed only when not undefined.

zachgoll commented 2 months ago

@AurelienConte yeah this would be a great first issue, you're welcome to take it!

AurelienConte commented 2 months ago

Okay ! Thanks i take it !

AurelienConte commented 2 months ago

I created a PR about this #844