search

maybeec / oomph-task-unzip

Oomph Task for unzipping archives
Eclipse Public License 1.0
1 stars 3 forks source link

MSI extraction fails if whitespace in path #13

Closed maybeec closed 7 years ago

maybeec commented 7 years ago

If there is a whitespace in MSI file path, the extraction fails:

Execute: msiexec /a "I:\eclipse\Neuer Ordner\temp\nodejs.msi" /qn TARGETDIR="I:\eclipse\Neuer Ordner\software\nodejs\" @ I:\eclipse\Neuer Ordner
Performing cli install.nodejs.cleanup.msi
Execute: del "I:\eclipse\Neuer Ordner\software\nodejs\nodejs.msi" @ I:\eclipse\Neuer Ordner
I:\eclipse\Neuer Ordner\software\nodejs\nodejs.msi konnte nicht gefunden werden
themetalone commented 7 years ago

How is this related to the unzip task?

maybeec commented 7 years ago

sry... I was guessing, that this part of the unzip task. But you are right, hat is part of the profile. Would it make sense to let the unzip task support msi?

themetalone commented 7 years ago

I can test if the apache commons compress library can handle it.

maybeec commented 7 years ago

I don't think so, there are some pitfalls with msi, so maybe we should not integrated it. Basically, whenever extracting an MSI it will waste your registry with additional garbage, which can be hardly circumvented. I tried it somehow without success. See eirslett/frontend-maven-plugin#490 and the comments on my PR as well as the upcoming issues in https://github.com/eirslett/frontend-maven-plugin/issues/503#issuecomment-258754636