search

maybegreat48 / GTA-V-Script-Decompiler

A program that can decompile script resource (ysc) files for the PC version of Grand Theft Auto V and Red Dead Redemption 2
67 stars 20 forks source link

Put the resolved label string as a comment #2

Closed Lucas7yoshi closed 1 year ago

Lucas7yoshi commented 1 year ago

In my opinion this is preferable because it maintains functionality, the native expects a label generally when its used, so makes sense to maintain that and instead put the value of it in a comment

Before

if (!HUD::IS_HELP_MESSAGE_BEING_DISPLAYED())
    HUD::DISPLAY_HELP_TEXT_THIS_FRAME(_("Only Pegasus or Personal aircraft can be stored in the Hangar."), false);

After

if (!HUD::IS_HELP_MESSAGE_BEING_DISPLAYED())
    HUD::DISPLAY_HELP_TEXT_THIS_FRAME("HANGAR_ENTER1" /*Only Pegasus or Personal aircraft can be stored in the Hangar.*/, false);
maybegreat48 commented 1 year ago

Fixed in https://github.com/maybegreat48/GTA-V-Script-Decompiler/commit/7fa8d9559399fa96baa158e7658128b9ab9d7e07