Closed mayer79 closed 3 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 87.17949%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 87.83%. Comparing base (
20247e3
) to head (77037c1
). Report is 11 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
R/missRanger.R | 84.94% | 14 Missing :warning: |
R/pmm.R | 94.11% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a large PR that refactors the way missRanger() deals with variables that cannot be directly modeled by ranger(). The new implementation is slightly more picky, but also more safe.
It is an important step towards out-of-sample application (https://github.com/mayer79/missRanger/issues/58).
Here a summary:
pmm()
is more picky:xtrain
andxtest
must both be either numeric, logical, or factor (with identical levels).ranger()
arguments are now explicit arguments inmissRanger()
to improve tab-completion experience: