mayer79 / missRanger

Fast multivariate imputation by random forests.
https://mayer79.github.io/missRanger/
GNU General Public License v2.0
63 stars 11 forks source link

Refactor datatype logic #68

Closed mayer79 closed 3 months ago

mayer79 commented 3 months ago

This is a large PR that refactors the way missRanger() deals with variables that cannot be directly modeled by ranger(). The new implementation is slightly more picky, but also more safe.

It is an important step towards out-of-sample application (https://github.com/mayer79/missRanger/issues/58).

Here a summary:

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.17949% with 15 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (20247e3) to head (77037c1). Report is 11 commits behind head on main.

Files Patch % Lines
R/missRanger.R 84.94% 14 Missing :warning:
R/pmm.R 94.11% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #68 +/- ## =========================================== - Coverage 97.95% 87.83% -10.13% =========================================== Files 5 5 Lines 245 263 +18 =========================================== - Hits 240 231 -9 - Misses 5 32 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.