mayerwin / vs-customize-window-title

Customize Visual Studio Window Title - Visual Studio Extension
https://marketplace.visualstudio.com/items?itemName=mayerwin.RenameVisualStudioWindowTitle
MIT License
108 stars 30 forks source link

Added DocumentDirtyResolver #53

Closed pstaszko closed 4 years ago

pstaszko commented 4 years ago

This is similar to an open item, but not quite the same https://github.com/mayerwin/vs-customize-window-title/issues/24

This only applies to the active document. I wasn't sure what to put for the output. A seems to be common in other editors (and the tabs in VS itself), but It seems like VS forces a in the title for it's own reasons and I wanted to avoid confusion. I tried to make it configurable like documentDirty: or documentDirty:[], but I couldn't figure that out. I hard coded [*]. I don't presume to suggest that this is great or whatever. I have never contributed to an open source project, so I'm not sure if I'm doing it correctly. I'm just really enthused that this cool extension exists, it's done so incredibly well, documented like a dream, written so nicely that it was super easy to extend, and I have a chance to contribute. Thanks!

mayerwin commented 4 years ago

Thanks! Released in V4.5.0 today. I have credited you. Great job on your first contribution! I actually was able to change the behavior of the extension to replace the * appended at the end of the title with a \t (tab), so we can use the * for relevant cases like this one. Please note I changed "Dirty" to "Unsaved" as it seemed more self-explanatory for people who may not be familiar with the jargon.

Originally I had set this appended string to * because it was useful for debugging purposes and I hadn't thought too much about, but people might have gotten used to it :). Hopefully they won't complain and appreciate the new improved cleanliness of the title.