search

mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

Add contribution templates + minor doc improvements #112

Closed Ma27 closed 5 years ago

Ma27 commented 5 years ago

This is just a proposal, I think it's helpful for first-time contributors to provide them a template which "tells" them what kind of information is needed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #112   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      133    133           
=======================================
  Files             6      6           
  Lines           556    556           
=======================================
  Hits            556    556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66e9244...05e641d. Read the comment docs.

Ma27 commented 5 years ago

fixed, train wifi seems to work today %)

Ma27 commented 5 years ago

@mmoll I slightly altered the PR and placed the breaking change part into its own section. Would you mind having another look? :)

mmoll commented 5 years ago

merged, danke @Ma27!