search

mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

suppress new phan error #115

Closed mmoll closed 5 years ago

mmoll commented 5 years ago

Type of PR

Breaking changes

Description

Please explain what you want to change and why. Additional information about the code and the commits may be helpful as well.

codecov[bot] commented 5 years ago

Codecov Report

Merging #115 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #115   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      133    133           
=======================================
  Files             6      6           
  Lines           556    556           
=======================================
  Hits            556    556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0dd7eac...69c9889. Read the comment docs.

Ma27 commented 5 years ago

for reference, it seems as this seems to have caused the issue we're experiencing: https://github.com/phan/phan/commit/409e1a04434cb9a3545b7ab64e725cec44199033#diff-51d74031f390b02c2f3cced18a13d964

@mmoll according to codeclimate the issue persists. Would you mind having a look?

mmoll commented 5 years ago

@Ma27 please see the actual codeclimate "error" ;)