mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

Require blank lines between class members #144

Closed Khartir closed 4 years ago

Khartir commented 4 years ago

Type of PR

Breaking changes

Description

Require exactly one blank line between class members, but not before the first and after the last one.

Example:

class Test
{
    /**
     * @var string
     */
    private $first;
    /**
     * @var int
     */
    private $second;

    /**
     * Test constructor.
     */
    public function __construct()
    {
    }
}

would become:

class Test
{
    /**
     * @var string
     */
    private $first;

    /**
     * @var int
     */
    private $second;

    /**
     * Test constructor.
     */
    public function __construct()
    {
    }
}
codecov[bot] commented 4 years ago

Codecov Report

Merging #144 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #144   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      133    133           
=======================================
  Files             6      6           
  Lines           556    556           
=======================================
  Hits            556    556

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e26f9c7...5f33ef8. Read the comment docs.

mmoll commented 4 years ago

merged, danke @Khartir!