search

mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

Refactor looping in ArrayDoubleArrowAlignmentSniff #153

Closed mmoll closed 2 years ago

mmoll commented 4 years ago

Psalm output:

ERROR: LoopInvalidation - MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php:95:21 - Variable $i has already been assigned in a for/foreach loop
                    $i = ($current['parenthesis_closer'] + 1);

ERROR: LoopInvalidation - MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php:97:21 - Variable $i has already been assigned in a for/foreach loop
                    $i = ($current['bracket_closer'] + 1);

ERROR: LoopInvalidation - MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php:105:17 - Variable $i has already been assigned in a for/foreach loop
                $i = ($current['scope_closer'] + 1);
xalopp commented 2 years ago

@mmoll is this stil relevant? In this case, could you provide the full command + settings to reproduce?

mmoll commented 2 years ago

@xalopp As it turns out, this fixed itself over time: GH-188