ruleset: disable `BlockControlStructureSpacing` sniff for most tokens

[Ma27]

Type of PR

• [ ] Bugfix
• [ ] New Feature
• [x] Other (explain): request for a change in our ruleset.

Breaking changes

• [ ] Yes, this is a breaking change

Description

I don't like this rule since variable assignments before such a block shouldn't be a blank-line away if those are related to the block itself.

For instance

$foo = 'bar';
if ($this->returnBool($foo)) {
    // ...
}

makes immediately clear that $foo is related to the control structure in contrast to

$foo = 'bar';

if ($this->returnBool($foo)) {
    // ...
}

[mmoll]

I'm unhappy with this, but let's vote with reactions +1/-1 above.

[codecov[bot]]

Codecov Report

Merging #165 (20584af) into master (f71240d) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #165   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       133       133           
===========================================
  Files              6         6           
  Lines            511       511           
===========================================
  Hits             511       511           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f71240d...20584af. Read the comment docs.

[xalopp]

This is related to #7 .

With #7 the empty line before control structures has been taken as a MO4 standard. Unsure if this decision can be reverted.

[Ma27]

@xalopp for now, the main question is IMHO whether you're in favor or against it :)

I think that a revert is fine if a feature is only removed if

• existing MO4 code is still valid (the decision is now up to the author whether to use a newline or not - I described in the OP why I think this makes sense here).
• we optionally release a new major release.

[Ma27]

Closing now as it seems as I'm the only one who seems to care about this.