search

mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

Refactor tests by introducting AbstractMo4SniffUnitTest #184

Closed xalopp closed 3 years ago

xalopp commented 3 years ago

Type of PR

Description

This refactoring reduces the amount of duplicate code an makes the tests cleaner, because the test cases focus on the tested file and the line that should contain warnings or errrors.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

codecov[bot] commented 3 years ago

Codecov Report

Merging #184 (1fea2e0) into master (b371b3d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #184   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       133       133           
===========================================
  Files              6         6           
  Lines            509       509           
===========================================
  Hits             509       509

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b371b3d...1fea2e0. Read the comment docs.

mmoll commented 3 years ago

merci @xalopp!