Closed mmoll closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c44311b
) 100.00% compared to head (a7890f8
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Khartir @valentin-schaeidt-mayflower could you check the Attributes rules in your respective project and report back if this fits your needs?
Minor issue: sorting the attributes alphabetically includes a leading \
in the order. This leads to #[\Attribute]
always being the last attribute, but that's a negligible edge-case.
More importantly, I just had this happen:
#[Bar()]
- // TODO do something
public function foo(): void
Thanks, I opened https://github.com/slevomat/coding-standard/pull/1497.
@Khartir Could you check again? :)
It still does weird stuff:
//phpcs:disable SlevomatCodingStandard.PHP.ForbiddenClasses
-#[Bar()] /** foo */
class TestCase
But I think we can merge this and either fix it upstream or disable offending sniffs downstream.
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication