mayflower / mo4-coding-standard

MO4 Coding Standard Rules for Codesniffer based on Symfony Coding Standards.
MIT License
17 stars 10 forks source link

Version 10 #207

Closed mmoll closed 7 months ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c44311b) 100.00% compared to head (a7890f8) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #207 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 150 150 =========================================== Files 8 8 Lines 611 669 +58 =========================================== + Hits 611 669 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmoll commented 1 year ago

@Khartir @valentin-schaeidt-mayflower could you check the Attributes rules in your respective project and report back if this fits your needs?

Khartir commented 1 year ago

Minor issue: sorting the attributes alphabetically includes a leading \ in the order. This leads to #[\Attribute] always being the last attribute, but that's a negligible edge-case.

More importantly, I just had this happen:

    #[Bar()]
-    // TODO do something
    public function foo(): void
mmoll commented 1 year ago

Thanks, I opened https://github.com/slevomat/coding-standard/pull/1497.

mmoll commented 10 months ago

@Khartir Could you check again? :)

Khartir commented 10 months ago

It still does weird stuff:

 //phpcs:disable SlevomatCodingStandard.PHP.ForbiddenClasses
-#[Bar()] /** foo */
 class TestCase

But I think we can merge this and either fix it upstream or disable offending sniffs downstream.

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud