search

maygupta / MyInstagram

0 stars 0 forks source link

Week 1 Instagram Client #1

Open maygupta opened 8 years ago

maygupta commented 8 years ago

My app has basic features ready but need some UI polishing and some advanced features. /cc @codepathreview @codepath

My question is should we submit the issue as soon as we have basic feature working like we did for Todo app and as and when we add new feature we add that as a comment or should we notify Codepath team at the very end when every thing is ready from our end ?

nidhi1608 commented 8 years ago

You can notify us when you're ready for us to review the entire app.

maygupta commented 8 years ago

Ok Thanks @nidhi1608

One question,
"Advanced: Display each photo with the same style and proportions as the real Instagram (see screens below)"

But isn't this already done by Picaso. I didn't do any scaling explicitly and the app renders the images with proper height and width without any stretching. I have added a demo in README just for the reference.

nidhi1608 commented 8 years ago

Yes, you can ignore that user story. I'll update the assignment.

maygupta commented 8 years ago

@nidhi1608

My app is ready for the review. I have skipped one of the item (to show the Video for video posts) since I am not sure if I will be able to take out time to work on that. If I do get time I will surely add that too. But I thought posting this early would be good for code review.

maygupta commented 8 years ago

@nidhi1608 Hi Nidhi, Just pinging again for your code review comments. Thanks, Mayank

nidhi1608 commented 8 years ago

Mayank, we'll be reviewing it tonight after the deadline.

On Mon, Oct 26, 2015 at 11:13 AM, maygupta notifications@github.com wrote:

@nidhi1608 https://github.com/nidhi1608 Hi Nidhi, Just pinging again for your code review comments. Thanks, Mayank

— Reply to this email directly or view it on GitHub https://github.com/maygupta/MyInstagram/issues/1#issuecomment-151233249.

codepathreview commented 8 years ago

:+1: Excellent work overall, good job getting most of the optional stories done. A few notes after checking out the code:

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.

P.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!

maygupta commented 8 years ago

Thanks for the detailed feedback. Its good to know what could be done better. Will work on these comments