mayhemer / logan

Log Analyzer for Mozilla logs
7 stars 4 forks source link

Think .follow() a bit more through #23

Closed mayhemer closed 7 years ago

mayhemer commented 7 years ago

follow is a bit misleading such as that it looks like it bounds somehow to the object. but it's actually not. by default follow() is canceled automatically when any other rule matches. if a code logs something matching between the rule that started the follow and the follow actually hits, that follow will be canceled silently.

hence, the auto-cancel condition should be more sophisticated.

mayhemer commented 7 years ago

It has changes so that we bound by module and thread in https://github.com/mayhemer/logan/commit/b9502e14b04b5b6afc439f4f2738d2409362e167