mayingzhen / nvidia-texture-tools

Automatically exported from code.google.com/p/nvidia-texture-tools
Other
0 stars 0 forks source link

mipmap should be built until BOTH w and h becomes 1 #156

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I found TexImage::buildNExtMipmap stops generating lower mipmap once EITHER of 
w and h becomes 1.  But I believe the correct behaviour should be stopping only 
after BOTH w and h becomes 1.

To do that i changed this code in TexImage::buildNextMipMap()

from:
    if (img == NULL || img->width() == 1 || img->height() == 1) {
        return false;
    }

to:

    if (img == NULL || img->width() == 1 && img->height() == 1) {
        return false;
    }

Original issue reported on code.google.com by pope...@gmail.com on 7 Dec 2010 at 9:45

GoogleCodeExporter commented 8 years ago
Good catch! Thanks for the bug report.

Original comment by cast...@gmail.com on 8 Dec 2010 at 7:53

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r1213.

Original comment by cast...@gmail.com on 8 Dec 2010 at 7:54