search

maykar / compact-custom-header

This project has been replaced by Custom Header
MIT License
238 stars 31 forks source link

Double Menu icons #165

Closed acordill closed 5 years ago

acordill commented 5 years ago

Describe the issue:

On beta of HA (0.96.0b1) there are two menu buttons, one in side bar and one on view. There should only be one.

Config YAML:

cch:
  active_tab_color: blue
  clock_date: true
  clock_format: '24'
  date_locale: en-US
  default_tab: '2'
  exceptions:
    - conditions:
        user: Andy
        user_agent: Linux x86_64
      config:
        clock_format: '24'
        default_tab: '2'
        hide_tabs: []
        menu: show
        notifications: show
        options: clock
        show_tabs: 2 to 12
        voice: overflow
    - conditions:
        user: Andy
        user_agent: Pixel 2 XL
      config:
        clock_format: '24'
        default_tab: '1'
        hide_tabs: []
        menu: show
        notifications: overflow
        options: clock
        show_tabs: '1,3 to 10,12'
        voice: overflow
    - conditions:
        user: Kiosk
      config:
        clock_format: '24'
        date_locale: en-US
        default_tab: '2'
        hide_tabs: []
        kiosk_mode: true
        menu: show
        notifications: overflow
        options: clock
        show_tabs: '2'
        sidebar_swipe: false
        voice: clock
    - conditions:
        user: Renee
      config:
        clock_format: '24'
        date_locale: en-US
        default_tab: '2'
        hide_tabs: []
        menu: show
        notifications: overflow
        options: clock
        show_tabs: '0 to 9,11,13'
        voice: overflow
  hide_help: true
  options: clock
  redirect: false
  show_tabs: 0 to 13
  sidebar_closed: true
  swipe: true
  swipe_prevent_default: true
  voice: overflow
  menu: overflow

HA and/or Browser Error:

No error messages that I am aware of

Versions and Browser:

CCH = 1.2.6 HA = 0.96.0b1 Browser = Chrome

maykar commented 5 years ago

Could you share a screenshot and does this happen on all devices (exceptions) for you or just one

maykar commented 5 years ago

Never mind, I was able to reproduce. I'm on it.

maykar commented 5 years ago

If you happen to be using HACS you can try the fix by pulling the "master" branch. If not, you can do so manually using the current js files on the repo. Just haven't pushed a release yet (don't want to release until there's more in there).

acordill commented 5 years ago

I am, thank you, will check it out now. Edit: FIXED