search

maykar / compact-custom-header

This project has been replaced by Custom Header
MIT License
238 stars 31 forks source link

Swipe groups not working at all #195

Closed jimz011 closed 5 years ago

jimz011 commented 5 years ago

Describe the issue:

When setting swipe_groups the swipe feature will stop working. No tabs can be swiped on. When commenting this line out it works again. I have tried single groups, multiple groups. Single and double quotes. Refresh, Clearing Cache. Nothing changed.

Config YAML:

menu: hide
options: hide
notifications: hide
voice: hide
header: false
chevrons: false
notify_indicator_color: "#e80000"
swipe: true
swipe_wrap: false
background: 'rgba(0,0,0,0.3)'
hide_tabs: '5 to 30'
default_tab: 1
swipe_groups: '0 to 4'

HA and/or Browser Error:

No Errors shown

Versions and Browser:

CCH Version: 1.3.6 HA Version: 0.98.4 Browser: HA app on iOS (so probably safari)

maykar commented 5 years ago

Can you try adding swipe_skip_hidden: false? I think this is may be due to the fact that you're hiding the entire header, so all tabs are seen as hidden and it's skipping all of them.

jimz011 commented 5 years ago

I have tried this but to no success. I also found that when using the latest version it would often throw a lovelace error when swiping in quick succession. It will throw a “reload lovelace” page or a unauthorized login screen (which happens sometimes already but a lot more often with the latest build). I do not experience these problems on older versions 1.3.5 I believe.

skynet01 commented 5 years ago

i can confirm i have the same behavior on 1.3.8. Groups are set up as an exception on an iPad. Also on iPad if you set hide the header sometimes it doesn't hide and big top area is empty. Rolled back to 1.3.5

cch:
  exceptions:
    - conditions:
        user_agent: iPad
      config:
        compact_header: false
        default_tab: []
        header: false
        hide_tabs: []
        menu: show
        notifications: show
        options: show
        show_tabs: []
        swipe: true
        swipe_amount: '20'
        swipe_animate: swipe
        swipe_prevent_default: true
        swipe_skip: '3'
        voice: show
  hide_help: true
  hide_tabs: '4'
  options: clock
  voice: clock
maykar commented 5 years ago

Just released 1.3.9 to address these issues as well as attempt to fix some of the iOS strangeness surrounding the "swipe" animation (got an iPad for testing!). Be sure to clear cache/ refresh. I added the version number to the CCH settings window so you can check that you are using the latest and not a cached version on mobile devices. Let me know if it helps.

skynet01 commented 5 years ago

I can confirm that swiping now works with 1.4.0. However i still have a big space at the top that shows up. This is on iPad Air2 IMG_246A4BDFBDDE-1

maykar commented 5 years ago

Try this:

cch:
  exceptions:
    - conditions:
        user_agent: iPad
      config:
        header: false
        hide_tabs: ""
        menu: show
        notifications: show
        options: show
        swipe: true
        swipe_amount: '20'
        swipe_animate: swipe
        swipe_prevent_default: true
        swipe_skip: '3'
        voice: show
  hide_help: true
  hide_tabs: '4'
  options: clock
skynet01 commented 5 years ago

yep, fixed it :) Was it the brackets?

maykar commented 5 years ago

The brackets in default_tab. I added a check for it the next release just in case.

maykar commented 5 years ago

Closing this one as the original issue for swipe_groups seems remedied as well as the iOS swipe navigation issues.