search

maykar / compact-custom-header

This project has been replaced by Custom Header
MIT License
239 stars 31 forks source link

Swipe navigation trigger with thermostat card #207

Closed glmnet closed 4 years ago

glmnet commented 4 years ago

Describe the issue:

When changing temperature range you slide the knob and this causes a navigation event. I believe the same happens with dimmable lights

Config YAML:

HA and/or Browser Error:

Versions and Browser:

close-issue-app[bot] commented 4 years ago

As described in the issue template, issues missing the required info will be closed. Please open a new issue, fill in as much as you can, and do not remove anything in the template.

maykar commented 4 years ago

Thank you, I'll look into it. I'll also look into removing this bot. It's helpful to get all the required info for most issues, but for things like this it's unnecessary.

glmnet commented 4 years ago

Ahh sorry, I used a mobile app which did not show the template.

Can you mark the issue open then? Thanks

maykar commented 4 years ago

Edited your first post and reopened.

glmnet commented 4 years ago

May be this component https://github.com/thomasloven/round-slider/ could swallow (not bubble up) the swipe event? I'm just saying (don't know the code details), this component was recently updated in HA .99

maykar commented 4 years ago

So I have been adding to a list of "ignored" cards and while it's not the most elegant solution it's worked so far. I should be trying to detect a card that needs ignored (like: if card has slider) and add to those variables instead. Otherwise the ignored list is going to get quite long.

maykar commented 4 years ago

Just released 1.3.9 that adds a fix for thermostat and lights. Thanks!