search

maykinmedia / charts

Maykinmedia Helm Charts
3 stars 2 forks source link

Setting the probes to empty dicts breaks the indentation #119

Open SilviaAmAm opened 2 months ago

SilviaAmAm commented 2 months ago

In openarchiefbeheer, setting these fields in the values.yaml:

livenessProbe: {}
readinessProbe: {}

results in

charts/charts/openarchiefbeheer$ helm lint .
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 56: did not find expected key

Error: 1 chart(s) linted, 1 chart(s) failed

While setting the probes to:

livenessProbe:
  initialDelaySeconds: 60
  periodSeconds: 10
  timeoutSeconds: 5
  failureThreshold: 6
  successThreshold: 1

readinessProbe:
  initialDelaySeconds: 30
  periodSeconds: 10
  timeoutSeconds: 5
  failureThreshold: 6
  successThreshold: 1

Results in a chart without errors when running helm lint.

We need to find a way to disable the probes without breaking the chart.

sjoerdie commented 2 months ago

Example: https://github.com/bitnami/charts/blob/main/bitnami/grafana/templates/deployment.yaml