maykinmedia / django-digid-eherkenning

Django library to use DigiD or eHerkenning to authenticate users
MIT License
2 stars 0 forks source link

[#3950] Make service catalogue more consistent with Signicat template #63

Closed SilviaAmAm closed 7 months ago

SilviaAmAm commented 8 months ago

Fixes https://github.com/open-formulieren/open-forms/issues/3950 (first checkbox)

Context Signicat, one of the Identity Providers for eHerkenning, said that the service catalogue that we generated was 'invalid'. The Signicat template can be found here: https://developer.signicat.com/broker/eherkenning-broker/eherkenning-service-catalogue.html#introduction

The noticed differences are mentioned in the ticket.

The service catalogue gets validated against this XSD: https://afsprakenstelsel.etoegang.nl/display/as/Service+catalog (under XML schema Service Catalog)

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.10%. Comparing base (970d3ed) to head (38ef6ed). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #63 +/- ## ========================================== + Coverage 96.01% 96.10% +0.08% ========================================== Files 72 73 +1 Lines 3216 3260 +44 ========================================== + Hits 3088 3133 +45 + Misses 128 127 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SilviaAmAm commented 8 months ago

Discussion with Joeri: