search

maykinmedia / django-digid-eherkenning

Django library to use DigiD or eHerkenning to authenticate users
MIT License
2 stars 0 forks source link

:fire: Remove oidc_exempt_urls from config models #76

Closed stevenbal closed 4 months ago

stevenbal commented 4 months ago

this field was never actually used, and it does not make sense to make settings that refer to Django stuff (URL patterns in this case) manually configurable instead of programmatically. It caused issues in Open Forms (#4435) where it required manual action from admins if it was kept as a model field.

requires https://github.com/maykinmedia/mozilla-django-oidc-db/pull/112 to be merged+released and version to be increased in pyproject.toml

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.85%. Comparing base (874ab6a) to head (51c051b). Report is 40 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #76 +/- ## ======================================= Coverage 90.85% 90.85% ======================================= Files 51 51 Lines 1651 1651 Branches 152 152 ======================================= Hits 1500 1500 Misses 110 110 Partials 41 41 ``` | [Flag](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/76/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | Coverage Δ | | |---|---|---| | [base](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/76/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `89.35% <ø> (ø)` | | | [oidc](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/76/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.