search

maykinmedia / django-digid-eherkenning

Django library to use DigiD or eHerkenning to authenticate users
MIT License
2 stars 0 forks source link

Move support for encrypted private key #78

Closed sergei-maertens closed 3 months ago

sergei-maertens commented 3 months ago

This library is no longer responsible for decrypting the private key, instead the django-simple-certmanager library takes care of it at upload time.

Includes a data migration to perform the decryption for existing instances.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.91%. Comparing base (170d6a9) to head (ffb17ba). Report is 34 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #78 +/- ## ========================================== + Coverage 90.86% 90.91% +0.05% ========================================== Files 51 51 Lines 1653 1674 +21 Branches 152 156 +4 ========================================== + Hits 1502 1522 +20 Misses 110 110 - Partials 41 42 +1 ``` | [Flag](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/78/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | Coverage Δ | | |---|---|---| | [base](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/78/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `89.44% <ø> (+0.07%)` | :arrow_up: | | [oidc](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/78/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sergei-maertens commented 3 months ago

@Viicos correct!