search

maykinmedia / django-digid-eherkenning

Django library to use DigiD or eHerkenning to authenticate users
MIT License
2 stars 0 forks source link

Support multiple certificates for DigiD/eHerkenning #79

Closed sergei-maertens closed 3 months ago

sergei-maertens commented 3 months ago

Closes #74

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.73418% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.97%. Comparing base (fc9abd3) to head (e6c9c1e). Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
digid_eherkenning/models/base.py 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #79 +/- ## ========================================== + Coverage 90.91% 91.97% +1.05% ========================================== Files 51 48 -3 Lines 1674 1645 -29 Branches 156 153 -3 ========================================== - Hits 1522 1513 -9 + Misses 110 96 -14 + Partials 42 36 -6 ``` | [Flag](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/79/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | Coverage Δ | | |---|---|---| | [base](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `90.64% <98.73%> (+1.20%)` | :arrow_up: | | [oidc](https://app.codecov.io/gh/maykinmedia/django-digid-eherkenning/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.