search

maykinmedia / django-label-loaders

MIT License
2 stars 0 forks source link

django-label-loaders vs. django-template-labels #1

Open reduxionist opened 6 years ago

reduxionist commented 6 years ago

While it's no real impediment to using the code, I thought you'd like to know that the name passed as setup's url arg currently 404s (the readme also uses the python name in main heading and body text but uses the github name for the badge links which aren't hiddenwhen README'ing from the cli). Normally I would just submit a fix by PR, but while the github project name matches the module's name, the setup url correctly refers to the python package name... "django-label-template-loaders" seems like a mouthful to me, even by Django standards, so I'll leave the naming to you and just go work on some cache invalidation instead... ;)

Thanks for sharing your code!

sergei-maertens commented 6 years ago

Yeah, we should take a look at the naming thing - I think I originally developed it to load only templates based on a label set, but the repo was creating with extending this behaviour to staticfiles as well.

We're not actively adding features to this at the time, so can't make any promises that we'll do anything about it at this point :)

reduxionist commented 6 years ago

That's cool, it wasn't much of an issue but I just wanted to give you the headsup in case you weren't aware. Thanks for replying nonetheless! 😀

sergei-maertens commented 6 years ago

Thanks for reporting, much appreciated!