Config model claim mapping validation catches incorrect exception

maykinmedia / mozilla-django-oidc-db

Database-backed settings for mozilla-django-oidc, with modified unique identifiers for users

MIT License

4 stars 0 forks source link

Config model claim mapping validation catches incorrect exception #92

Closed stevenbal closed 4 months ago

stevenbal commented 5 months ago

https://github.com/maykinmedia/mozilla-django-oidc-db/blob/fb09fff0638d80cdc858b64db0619d1e6a4f64e8/mozilla_django_oidc_db/models.py#L328

File "/env/lib/python3.11/site-packages/mozilla_django_oidc_db/models.py", line 321, in clean
    except models.FieldDoesNotExist:
           ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'django.db.models' has no attribute 'FieldDoesNotExist'

sergei-maertens commented 4 months ago

Happens on django 3.2, 4.2 and 5.0. Should be easy to write a regression test for it.