search

maykinmedia / objects-api

API and admin interface to manage Objects of certain Objecttypes. An object can be anything whether its a monument, report, tree or a permit.
https://opengem.nl/producten/overige-registraties/
Other
7 stars 10 forks source link

:bug:[#449] support objecttypes API with pagination #454

Closed Coperh closed 1 week ago

Coperh commented 1 week ago

Fixes #449

Supports paginated response from OT V2

Coperh commented 1 week ago

Idk why this is failing, I'll look into it later

edit: fixed

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.31%. Comparing base (a5a0a50) to head (6baedab). Report is 59 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #454 +/- ## ========================================== + Coverage 95.18% 95.31% +0.13% ========================================== Files 150 155 +5 Lines 5105 5485 +380 ========================================== + Hits 4859 5228 +369 - Misses 246 257 +11 ``` | [Flag](https://app.codecov.io/gh/maykinmedia/objects-api/pull/454/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/maykinmedia/objects-api/pull/454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `95.31% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.