search

maykinmedia / open-archiefbeheer

0 stars 0 forks source link

:lipstick: #227 - fix: fix a bug that prevent the list of short proce… #241

Closed svenvandescheur closed 1 month ago

svenvandescheur commented 1 month ago

…dure zaaktypen from being empty

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.59%. Comparing base (b987df2) to head (84d7784). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #241 +/- ## =========================================== + Coverage 78.84% 91.59% +12.75% =========================================== Files 188 131 -57 Lines 5437 4666 -771 Branches 100 0 -100 =========================================== - Hits 4287 4274 -13 + Misses 1052 392 -660 + Partials 98 0 -98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

svenvandescheur commented 1 month ago

@SilviaAmAm I'm not sure, this sound to me like the most simple solution and works in the admin as well as in the API. IMO if the API can infer the behavior from the model there is no reason to implement otherwise and move this up higher in the chain (limiting the effectiveness of the change) but I might be wrong.

Your call ;-)

SilviaAmAm commented 1 month ago

I was having a look and actually on main the API can already accept an empty list for the short zaaktypes. So maybe it should even be a frontend fix?

SilviaAmAm commented 1 month ago

I was having a look and actually on main the API can already accept an empty list for the short zaaktypes. So maybe it should even be a frontend fix?

I was wrong! The current fix is fine!