search

maykinmedia / open-archiefbeheer

0 stars 0 forks source link

[#262] Expand zaak details #271

Closed SilviaAmAm closed 2 months ago

SilviaAmAm commented 2 months ago

Partially fixes #262

I hesitate about keeping the zaak_url field :thinking: I worry that it might get out of sync. But if we remove it then we no longer have the URL of the zaak once it is deleted... (for both items with status 'suggested' or 'removed').

Discussed with Sven: remove zaak_url field

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 95.43379% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (2bd1d8f) to head (248270d).

Files Patch % Lines
...ackend/src/openarchiefbeheer/destruction/models.py 76.92% 3 Missing :warning:
...uction/migrations/0017_destructionlistitem_zaak.py 92.85% 2 Missing :warning:
...c/pages/destructionlist/hooks/useDataGridProps.tsx 0.00% 0 Missing and 2 partials :warning:
.../openarchiefbeheer/utils/tests/migrations_tests.py 96.87% 1 Missing :warning:
...onents/DestructionListEdit/DestructionListEdit.tsx 0.00% 1 Missing :warning:
...ListProcessReview/DestructionListProcessReview.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## ========================================== + Coverage 9.69% 77.93% +68.23% ========================================== Files 65 208 +143 Lines 1031 6027 +4996 Branches 116 116 ========================================== + Hits 100 4697 +4597 - Misses 824 1223 +399 Partials 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.