search

maykinmedia / open-archiefbeheer

0 stars 0 forks source link

:sparkles: - feat: implemented button to clear selection #286

Closed Xaohs closed 3 weeks ago

Xaohs commented 3 weeks ago

closes #230

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.07%. Comparing base (4a9147c) to head (5bad839). Report is 13 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #286 +/- ## =========================================== + Coverage 77.84% 92.07% +14.22% =========================================== Files 211 143 -68 Lines 6080 5032 -1048 Branches 120 0 -120 =========================================== - Hits 4733 4633 -100 + Misses 1236 399 -837 + Partials 111 0 -111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Xaohs commented 3 weeks ago

DRAFT: Reason being -> ideally we'd like to use the selectedResults in useDataGridProps.tsx but this prop seems to not be only functioning correctly on page-refresh/entry.

This current PR does seem to do what we want it to do, and it does seem to function correctly though, although it is not optimal

svenvandescheur commented 3 weeks ago

Replaced with: https://github.com/maykinmedia/open-archiefbeheer/pull/288