maykinmedia / open-archiefbeheer

0 stars 0 forks source link

Uitzonderingen beoordelen door recordmanager geeft niet de juiste response #377

Closed SilviaAmAm closed 1 month ago

SilviaAmAm commented 2 months ago

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258/backlog?selectedIssue=PZ-3968

Currently, if I select "Afwijzen van het voorstel" as an option when processing a review and I then I submit the review response, nothing happens.

Under the hood a 400 error happens when POSTing this json to /api/v1/review-responses/:

{
  "review": 47,
  "comment": "Testtt",
  "itemsResponses": [
    {
      "reviewItem": 28,
      "actionItem": "keep",
      "actionZaak": {
        "selectielijstklasse": "3.1.6 - Vastgesteld - blijvend_bewaren",
        "archiefactiedatum": "2025-07-21"
      },
      "comment": "Test"
    }
  ]
}

The error is:

{
  "itemsResponses": [
    {
      "actionZaak": {
        "selectielijstklasse": [
          "Voer een geldige URL in."
        ]
      }
    }
  ]
}

Expectation

To discuss. What should happen?

This is currently how we handle review responses: https://github.com/maykinmedia/open-archiefbeheer/blob/main/backend/src/openarchiefbeheer/destruction/models.py#L504

I think that this modal doesn't really make it clear what the actions are :thinking: The action is either "keep zaak in list" or "remove zaak from list" and (independent of it?) change selectielijst and/or bewaartermijn.

KarinMasselink commented 2 months ago

Selectielijstklasse:

Verlengen van bewaartermijn:

Afwijzen:

SilviaAmAm commented 2 months ago

Checked: the zaken on the test environment have a selectielijstklasse defined. But for some reason it is not picked up in the frontend. I will make another issue for this.

New issue: https://github.com/maykinmedia/open-archiefbeheer/issues/380