search

maykinmedia / open-archiefbeheer

0 stars 0 forks source link

[#378] Prevent crash if reviewItem has zaak = null #379

Closed SilviaAmAm closed 1 month ago

SilviaAmAm commented 2 months ago

Fixes #378

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 8.62069% with 53 lines in your changes missing coverage. Please review.

Project coverage is 76.52%. Comparing base (1899acd) to head (758c0f3).

Files with missing lines Patch % Lines
...ion/tests/e2e/features/test_feature_list_review.py 9.09% 20 Missing :warning:
...s/e2e/features/test_feature_list_process_review.py 9.52% 19 Missing :warning:
...ructionlist/detail/DestructionListDetail.loader.ts 0.00% 2 Missing and 4 partials :warning:
frontend/src/fixtures/reviewItem.ts 0.00% 4 Missing :warning:
...ructionlist/review/DestructionListReview.loader.ts 0.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ========================================== - Coverage 76.94% 76.52% -0.43% ========================================== Files 240 240 Lines 7504 7552 +48 Branches 158 160 +2 ========================================== + Hits 5774 5779 +5 - Misses 1583 1624 +41 - Partials 147 149 +2 ``` | [Flag](https://app.codecov.io/gh/maykinmedia/open-archiefbeheer/pull/379/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/maykinmedia/open-archiefbeheer/pull/379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia) | `76.52% <8.62%> (-0.43%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=maykinmedia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.