✨ [#147] Convenience endpoint for Klantcontact/Betrokkene/Onderwerpobject

maykinmedia / open-klant

Registratiecomponent voor de opslag en ontsluiting van klantgegevens volgens de Klantinteracties API-specificatie.

Other

2 stars 3 forks source link

Closed stevenbal closed 4 weeks ago

stevenbal commented 1 month ago

Fixes #147

Changes

stevenbal commented 1 month ago

I had several questions, mostly related to the datamodel itself, because I haven't looked at it before:

should it be possible to pass Onderwerpobject.wasKlantcontact via convenience endpoint? Why does this field exist in the first place? -> yes
should it be possible to create without Onderwerpobject? -> yes
why does Betrokkene have had_klantcontact/klantcontact and was_partij/partij? -> naming to avoid having to use "was_partij" everywhere in the code

joeribekker commented 1 month ago

@stevenbal nog even bespreken? Voordat je merged :)

stevenbal commented 1 month ago

@joeribekker ja dat lijkt me goed, was ook nog niet van plan het te mergen :p

joeribekker commented 1 month ago

@stevenbal please contact me on Slack to discuss when you pick this up again.

stevenbal commented 1 month ago

@bart-maykin I discussed with Joeri and I made both Betrokkene and OnderwerpObject optional on the convenience endpoint