sergei-maertens commented 2 years ago

Fixes #49

@alextreme - is there any chance you could try out this branch/fix in OIP before we merge it?

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (5e4603c) into main (53c8562) will increase coverage by 20.29%. The diff coverage is 74.43%.

@@             Coverage Diff             @@
##             main      #50       +/-   ##
===========================================
+ Coverage   45.68%   65.98%   +20.29%     
===========================================
  Files          36       36               
  Lines        1357     1367       +10     
  Branches      223      223               
===========================================
+ Hits          620      902      +282     
+ Misses        700      415      -285     
- Partials       37       50       +13

Impacted Files	Coverage Δ
zgw_consumers/api_models/besluiten.py	`0.00% <0.00%> (ø)`
zgw_consumers/api_models/documenten.py	`0.00% <0.00%> (ø)`
zgw_consumers/api_models/base.py	`63.51% <70.00%> (+31.20%)`	:arrow_up:
zgw_consumers/api_models/catalogi.py	`94.65% <100.00%> (+94.65%)`	:arrow_up:
zgw_consumers/api_models/zaken.py	`94.18% <100.00%> (+94.18%)`	:arrow_up:
zgw_consumers/api_models/_camel_case.py	`65.78% <0.00%> (+44.73%)`	:arrow_up:
zgw_consumers/api_models/constants.py	`100.00% <0.00%> (+100.00%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

alextreme commented 2 years ago

Sure I'll give this a spin later this afternoon on OIP acceptance. Thanks for the quick turnaround!

alextreme commented 2 years ago

Unfortunately I wasn't easily able to switch zgw_consumers out, we're on 0.18 and switching to 0.21 gave me sufficient simple_certmanager-errors that I didn't want to do this live on acceptance.

I did the next best thing and added a few tests based on the OIP acceptance data:

https://github.com/maykinmedia/zgw-consumers/pull/53

It seems the other party isn't returning sufficient mandatory data for the ZaakTypes and Zaak.

sergei-maertens commented 2 years ago

Thanks, I merged that and will look into it further.

alextreme commented 2 years ago

Umm that wasn't my intention, I suspect that if you do look into it that you'll want to remove these 2 tests :)

sergei-maertens commented 2 years ago

Umm that wasn't my intention, I suspect that if you do look into it that you'll want to remove these 2 tests :)

No worries, this makes it easy to check out and everything can go away through the power of rebase ;)

maykinmedia / zgw-consumers

Handle missing optional keys #50

Codecov Report