search

maykinmedia / zgw-consumers

Django app to store ZGW API configuration
MIT License
1 stars 2 forks source link

Issue/get paginated results #58

Closed annashamray closed 1 year ago

annashamray commented 1 year ago
  1. This PR fixes bug in get_paginated_results function, which was discovered in Open Inwoner. Now inside the loop in this function the page parameter is added to query_params variable which is not visible by the Client.request method
  2. ZGWClient can't see __init__ of its parent class. which leads to errors, so I removed @dataclass decorator
codecov[bot] commented 1 year ago

Codecov Report

Merging #58 (ddd8074) into main (0096aa3) will increase coverage by 3.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   66.56%   69.78%   +3.21%     
==========================================
  Files          32       32              
  Lines        1334     1337       +3     
  Branches      188      187       -1     
==========================================
+ Hits          888      933      +45     
+ Misses        395      348      -47     
- Partials       51       56       +5
Impacted Files Coverage Δ
zgw_consumers/client.py 81.25% <100.00%> (+20.93%) :arrow_up:
zgw_consumers/service.py 54.38% <100.00%> (+54.38%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more