search

mayn / packerlicious

use python to make hashicorp packer templates
Apache License 2.0
103 stars 51 forks source link

Shutdown behavior is a string per packer documentation. Does not acce… #123

Closed levisbakalinsky closed 6 years ago

levisbakalinsky commented 6 years ago

Shutdown behavior is a string per packer documentation. Does not accept a string in a list

Issue

https://github.com/mayn/packerlicious/issues/122

List of Changes Proposed

Changing validation from [str] to str

Testing Evidence

Packer validate no longer throws an error as described in the issue.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d92a983e9a23a217c7993fa76d37ca261d8aaf45 on levisbakalinsky:shutdown_validation into f3793b8ae8300916103205a51b76ad94a5c08453 on mayn:master.

mayn commented 6 years ago

@levisbakalinsky Thanks. Do you mind pushing up changes for AmazonEbsSurrogate and AmazonEbsVolume also.

levisbakalinsky commented 6 years ago

Sure. Will get it out later today.